Use the TooltippedIconButton in toolbars
#319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
jtpio
reviewed
Dec 8, 2025
packages/jupyter-chat/src/components/input/buttons/cancel-button.tsx
Outdated
Show resolved
Hide resolved
| props: TooltippedIconButtonProps | ||
| ): JSX.Element { | ||
| // Override the default icon font size from 'medium' to 'small' | ||
| props.children.props.fontSize = props.fontSize ?? 'small'; |
Member
There was a problem hiding this comment.
Should the props be directly mutated? Wondering if there could be side-effects to this.
Collaborator
Author
There was a problem hiding this comment.
AFAIU, if one wants to use a bigger button (iconButtonProps.size = 'large'), it makes probably sense to be able to set the font size too.
Co-authored-by: Jeremy Tuloup <[email protected]>
Collaborator
Author
|
Thanks for the review @jtpio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restore the use of
TooltippedIconButtonin chat toolbars (input, message and code), that has been partially removed in #298.It aligns the tooltipped buttons style to the recent changes in button UI brought by #298.
This will help homogenize the buttons in the chat itself, but also for extension adding buttons to the input toolbar.
Related to #303
Could help with jupyterlite/ai#218
cc. @jtpio @ellisonbg